workflows: fix name of build tarball for RB1 #63
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lool
reviewed
May 28, 2025
Contributor
lool
left a comment
lool
left a comment
There was a problem hiding this comment.
We discussed this, and I'd prefer if we said "emmc" or "ufs" in the ci/lava/ files somewhere, instead of adding another per board switch statement
RB1 uses flash-emmc.tar.gz. So far test.yml had flash-ufs.tar.gz hardcoded. This patch moves the file name of the flash package to the respective LAVA template. Signed-off-by: Milosz Wasilewski <[email protected]>
mwasilew
force-pushed
the
workflows/fix-tarball-name-rb1
branch
from
e88f4bc to
625423e
Compare
Contributor
|
Looks good to me, thanks! |
Test jobs for commit 625423e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RB1 uses flash-emmc.tar.gz. So far test.yml had flash-ufs.tar.gz hardcoded. This patch adds support for chaning the tarball name depending on the board type.